From ff8c8a5336c59f628678ff8b42342fc9ad6cf576 Mon Sep 17 00:00:00 2001 From: Edward <edward.sabinus@informatik.uni-halle.de> Date: Wed, 6 Dec 2023 17:28:08 +0100 Subject: [PATCH] replaced maxpt with confpt in assessment formula to not punish twice for not enough steps --- BewerterStrukturellerInduktion/Bewertung/Bewerter.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BewerterStrukturellerInduktion/Bewertung/Bewerter.cs b/BewerterStrukturellerInduktion/Bewertung/Bewerter.cs index 1760d98..27e1088 100644 --- a/BewerterStrukturellerInduktion/Bewertung/Bewerter.cs +++ b/BewerterStrukturellerInduktion/Bewertung/Bewerter.cs @@ -62,7 +62,7 @@ namespace Bewertung { InductionCaseConfig icConfig = indConf.GetIndCaseConfig(ic.Constructor); if (icConfig == null) throw new Exception("Cannot find config for induction case " + ic.Constructor.name + "."); double confPt = base.confPt(icConfig.config.maxPt, abstrMaxPt, icConfig.config.minSteps); - aO.findIPA("Fall " + ic.Constructor.name).Assessment = Math.Max(0.0, confPt - icConfig.config.maxPt * errorPoints / Math.Max(1.0, Math.Min(icConfig.config.maxSteps, abstrMaxPt))); + aO.findIPA("Fall " + ic.Constructor.name).Assessment = Math.Max(0.0, confPt - confPt * errorPoints / Math.Max(1.0, Math.Min(icConfig.config.maxSteps, abstrMaxPt))); } foreach (InductionPartAssessment ipa in aO.confIndAssessment) aO.assessment += ipa.Assessment; @@ -76,7 +76,7 @@ namespace Bewertung { errorPoints = errorPoints / Math.Max(1.0, Math.Min(sConf.maxSteps, aO.AbstractMaxTaskPoints())); if (containsError23(mainLemma)) errorPoints += weights[5]; double confPt = base.confPt(aO.task.config.MaxPt(), aO.AbstractMaxTaskPoints(), sConf.minSteps); - aO.assessment = Math.Max(0.0, confPt - (aO.task.config.MaxPt() * errorPoints)); + aO.assessment = Math.Max(0.0, confPt - (confPt * errorPoints)); } } bool containsError23(Lemma lemma) -- GitLab