From ea26d9a855aa0d1592a2dcceda95d992edfd77cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Janis=20Daniel=20Da=CC=88hne?=
<janis.daehne2@student.uni-halle.de>
Date: Thu, 14 Nov 2019 23:24:29 +0100
Subject: [PATCH] - fixed annoying flickering when running tests and the list
of tests gets more height and shows a jumping scrollbar
---
.../doExerciseSite/customTestsPanel/customTestsPanelView.tsx | 3 ++-
src/components/sites/doExerciseSite/testsPanel/styles.styl | 4 ++--
src/components/sites/doExerciseSite/testsPanel/testNumber.tsx | 2 +-
.../sites/doExerciseSite/testsPanel/testsPanelView.tsx | 3 ++-
src/constants.ts | 2 +-
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/components/sites/doExerciseSite/customTestsPanel/customTestsPanelView.tsx b/src/components/sites/doExerciseSite/customTestsPanel/customTestsPanelView.tsx
index a478fd14..39e9d49d 100644
--- a/src/components/sites/doExerciseSite/customTestsPanel/customTestsPanelView.tsx
+++ b/src/components/sites/doExerciseSite/customTestsPanel/customTestsPanelView.tsx
@@ -84,7 +84,8 @@ class TestsPanel extends React.Component<Props, any> {
)
.map((customTest, index) => {
return (
- <List.Item key={customTest.id}
+ //style hidden is needed because the test running animation (.test-running) rotates and box heights gets bigger... after 45 deg
+ <List.Item key={customTest.id} style={{overflow: 'hidden'}}
className={`test-line pad-left-right default-cursor fg-colored ` +
(this.props.selectedConsoleViewTest
&& this.props.selectedConsoleViewTest.id === customTest.id
diff --git a/src/components/sites/doExerciseSite/testsPanel/styles.styl b/src/components/sites/doExerciseSite/testsPanel/styles.styl
index 1909c7e1..96d98d2e 100644
--- a/src/components/sites/doExerciseSite/testsPanel/styles.styl
+++ b/src/components/sites/doExerciseSite/testsPanel/styles.styl
@@ -80,7 +80,7 @@ $testNumberSize = 32px
/* display: inline-block;*/
min-width $testNumberSize
min-height $testNumberSize
- padding 0.1em
+ padding 1px
border-radius 50%
border-top-color transparent
border-bottom-color transparent
@@ -96,4 +96,4 @@ $testNumberSize = 32px
to {
transform rotate(360deg)
}
-}
\ No newline at end of file
+}
diff --git a/src/components/sites/doExerciseSite/testsPanel/testNumber.tsx b/src/components/sites/doExerciseSite/testsPanel/testNumber.tsx
index e53dbdb4..25cf3d5f 100644
--- a/src/components/sites/doExerciseSite/testsPanel/testNumber.tsx
+++ b/src/components/sites/doExerciseSite/testsPanel/testNumber.tsx
@@ -76,4 +76,4 @@ class testNumber extends React.Component<Props, any> {
}
}
-export default connect(mapStateToProps, mapDispatchToProps)(testNumber)
\ No newline at end of file
+export default connect(mapStateToProps, mapDispatchToProps)(testNumber)
diff --git a/src/components/sites/doExerciseSite/testsPanel/testsPanelView.tsx b/src/components/sites/doExerciseSite/testsPanel/testsPanelView.tsx
index 35274a23..5f978b95 100644
--- a/src/components/sites/doExerciseSite/testsPanel/testsPanelView.tsx
+++ b/src/components/sites/doExerciseSite/testsPanel/testsPanelView.tsx
@@ -139,7 +139,8 @@ class TestsPanel extends React.Component<Props, any> {
(test) => test.displayIndex)
.map((test, index) => {
return (
- <List.Item key={test.id}
+ //style hidden is needed because the test running animation (.test-running) rotates and box heights gets bigger... after 45 deg
+ <List.Item key={test.id} style={{overflow: 'hidden'}}
className={`test-line pad-left-right default-cursor fg-colored indicator-parent ` +
(this.props.selectedConsoleViewTest
&& this.props.selectedConsoleViewTest.id === test.id
diff --git a/src/constants.ts b/src/constants.ts
index d12b4604..ff3d5ef9 100644
--- a/src/constants.ts
+++ b/src/constants.ts
@@ -13,7 +13,7 @@ import Logger from './helpers/logger'
* y - breaking changes / new features
* z - fixes, small changes
*/
-export const versionString = '2.5.12'
+export const versionString = '2.5.13'
export const supportMail = 'yapex@informatik.uni-halle.de'
--
GitLab