From 6f2237dfab58a17707a7a8b29b372bc97b6b74ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Janis=20Daniel=20Da=CC=88hne?=
<janis.daehne2@student.uni-halle.de>
Date: Fri, 15 Nov 2019 02:26:45 +0100
Subject: [PATCH] - fixed potential issue where we try to skip a negative
amount when paging
---
src/ClientServer/Config/Constants.cs | 2 +-
src/ClientServer/Helpers/PaginationHelper.cs | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/ClientServer/Config/Constants.cs b/src/ClientServer/Config/Constants.cs
index 4aa8566..ad463b6 100644
--- a/src/ClientServer/Config/Constants.cs
+++ b/src/ClientServer/Config/Constants.cs
@@ -13,7 +13,7 @@ namespace ClientServer.Helpers
/// </summary>
public static class Constants
{
- public static string VersionString = "2.5.10";
+ public static string VersionString = "2.5.11";
/// <summary>
/// this is only set once at program.cs!!
diff --git a/src/ClientServer/Helpers/PaginationHelper.cs b/src/ClientServer/Helpers/PaginationHelper.cs
index 2e354cb..1160e3e 100644
--- a/src/ClientServer/Helpers/PaginationHelper.cs
+++ b/src/ClientServer/Helpers/PaginationHelper.cs
@@ -111,7 +111,8 @@ namespace ClientServer.Helpers
SearchText = searchText //just to forge the obj
};
- int skip = (page-1) * pageSize;
+ //this could get negative... if frontend gives bad values
+ int skip = Math.Max(0, (page-1) * pageSize);
var pagedQuery = query;
--
GitLab